Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

panic in hydrateJob #660

Merged
merged 1 commit into from
Jul 14, 2014
Merged

panic in hydrateJob #660

merged 1 commit into from
Jul 14, 2014

Conversation

jonboulle
Copy link
Contributor

Running fleet v0.5.3.

Jul 13 01:08:08 ip-10-123-139-220 fleet[2102]: I0713 01:08:08.920127 02102 client.go:274] Failed getting response from http://localhost:4001/: cancelled
Jul 13 01:08:08 ip-10-123-139-220 fleet[2102]: panic: runtime error: invalid memory address or nil pointer dereference
Jul 13 01:08:08 ip-10-123-139-220 fleet[2102]: [signal 0xb code=0x1 addr=0x0 pc=0x47c1a0]
Jul 13 01:08:08 ip-10-123-139-220 fleet[2102]: goroutine 325 [running]:
Jul 13 01:08:08 ip-10-123-139-220 fleet[2102]: runtime.panic(0x7092a0, 0xb58248)
Jul 13 01:08:08 ip-10-123-139-220 fleet[2102]: /usr/local/go/src/pkg/runtime/panic.c:266 +0xb6
Jul 13 01:08:08 ip-10-123-139-220 fleet[2102]: github.com/coreos/fleet/registry.(*EtcdRegistry).hydrateJob(0xc210093420, 0x0, 0x78, 0x0)
Jul 13 01:08:08 ip-10-123-139-220 fleet[2102]: /home/core/fleet/scripts/fleet/gopath/src/github.com/coreos/fleet/registry/job.go:126 +0x150
Jul 13 01:08:08 ip-10-123-139-220 fleet[2102]: github.com/coreos/fleet/registry.(*EtcdRegistry).Jobs(0xc210093420, 0x7c13f0, 0x24, 0x0, 0x0, ...)
Jul 13 01:08:08 ip-10-123-139-220 fleet[2102]: /home/core/fleet/scripts/fleet/gopath/src/github.com/coreos/fleet/registry/job.go:50 +0x608
Jul 13 01:08:08 ip-10-123-139-220 fleet[2102]: github.com/coreos/fleet/engine.(*Engine).Reconcile(0xc2100c29f0)
Jul 13 01:08:08 ip-10-123-139-220 fleet[2102]: /home/core/fleet/scripts/fleet/gopath/src/github.com/coreos/fleet/engine/engine.go:60 +0x7f
Jul 13 01:08:08 ip-10-123-139-220 fleet[2102]: github.com/coreos/fleet/engine.func<C2><B7>001()
Jul 13 01:08:08 ip-10-123-139-220 fleet[2102]: /home/core/fleet/scripts/fleet/gopath/src/github.com/coreos/fleet/engine/engine.go:40 +0x1a2
Jul 13 01:08:08 ip-10-123-139-220 fleet[2102]: github.com/coreos/fleet/engine.(*Engine).Run(0xc2100c29f0, 0xc2101542a0)
Jul 13 01:08:08 ip-10-123-139-220 fleet[2102]: /home/core/fleet/scripts/fleet/gopath/src/github.com/coreos/fleet/engine/engine.go:50 +0x25a
Jul 13 01:08:08 ip-10-123-139-220 fleet[2102]: created by github.com/coreos/fleet/server.(*Server).Run
Jul 13 01:08:08 ip-10-123-139-220 fleet[2102]: /home/core/fleet/scripts/fleet/gopath/src/github.com/coreos/fleet/server/server.go:182 +0x238
Jul 13 01:08:08 ip-10-123-139-220 fleet[2102]: goroutine 1 [chan receive]:
Jul 13 01:08:08 ip-10-123-139-220 fleet[2102]: main.listenForSignals(0xc210072bd0)
Jul 13 01:08:08 ip-10-123-139-220 fleet[2102]: /home/core/fleet/scripts/fleet/gopath/src/github.com/coreos/fleet/fleet.go:177 +0x12c
Jul 13 01:08:08 ip-10-123-139-220 fleet[2102]: main.main()

@jonboulle
Copy link
Contributor

Preceding log lines would be nice so we can see why getJobFromJSON returned nil..

@jonboulle jonboulle self-assigned this Jul 13, 2014
@bcwaldon
Copy link
Contributor Author

@jonboulle don't have them, seem to have been dropped by journald due to ratelimiting

jonboulle
jonboulle reviewed Jul 13, 2014
View reviewed changes
registry/job.go
@@ -42,7 +42,7 @@ func (r *EtcdRegistry) Jobs() ([]job.Job, error) {
}

j, err := r.getJobFromJSON(node.Value)
if err != nil {
if j == nil || err != nil {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cf line 114

@bcwaldon bcwaldon added this to the v0.6.0 milestone Jul 14, 2014
@bcwaldon
Copy link
Contributor Author

LGTM

jonboulle added a commit that referenced this pull request Jul 14, 2014
@jonboulle
Merge pull request #660 from jonboulle/660
733fa11 
panic in hydrateJob
@jonboulle jonboulle merged commit 733fa11 into coreos:master Jul 14, 2014
@bcwaldon bcwaldon modified the milestones: v0.5.4, v0.6.0 Jul 14, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jonboulle jonboulle

Labels
priority/P1
Projects
None yet
Milestone
v0.5.4
Development

Successfully merging this pull request may close these issues.
2 participants
@jonboulle @bcwaldon